Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignore] fix plan does not detect read-only attributes changed when nothing else is changed in plan (DCNE-266) #1310

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

akinross
Copy link
Collaborator

No description provided.

@akinross akinross force-pushed the 1307_bug_fix_read_only_legacy_block branch 4 times, most recently from 26f19eb to 35e3e19 Compare January 24, 2025 21:50
@akinross akinross force-pushed the 1307_bug_fix_read_only_legacy_block branch from 35e3e19 to a8cc8aa Compare January 26, 2025 11:28
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two acceptance tests are failing: resource_aci_endpoint_security_group_test is failing for both of them. Error: "After applying this test step, the non-refresh plan was not empty."
Is it normal?

@akinross
Copy link
Collaborator Author

The two acceptance tests are failing: resource_aci_endpoint_security_group_test is failing for both of them. Error: "After applying this test step, the non-refresh plan was not empty." Is it normal?

Yes I am aware, please review regardless of this failure. This is a side affect I am still investigating where tDn is not resolved quick enough, so the refresh is triggered but the tDn value in plan would be unknown because the state value (not configurable but set by ACI) is deviating from the plan.

@akinross akinross requested a review from gmicol January 27, 2025 18:57
@akinross akinross force-pushed the 1307_bug_fix_read_only_legacy_block branch from fcd745e to 95ff302 Compare January 28, 2025 14:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 67.63881% with 577 lines in your changes missing coverage. Please review.

Project coverage is 86.81%. Comparing base (5dff413) to head (31c4cd5).

Files with missing lines Patch % Lines
internal/provider/resource_aci_application_epg.go 63.34% 200 Missing and 61 partials ⚠️
internal/provider/resource_aci_bridge_domain.go 75.83% 98 Missing and 11 partials ⚠️
...l/provider/resource_aci_endpoint_security_group.go 78.87% 54 Missing and 21 partials ⚠️
...nternal/provider/resource_aci_custom_qos_policy.go 30.76% 54 Missing and 18 partials ⚠️
...rnal/provider/resource_aci_l3out_consumer_label.go 61.53% 15 Missing and 5 partials ⚠️
.../provider/resource_aci_vrf_fallback_route_group.go 44.44% 15 Missing and 5 partials ⚠️
...ci_external_management_network_instance_profile.go 57.14% 9 Missing and 3 partials ⚠️
...al/provider/resource_aci_netflow_monitor_policy.go 66.66% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
+ Coverage   85.70%   86.81%   +1.10%     
==========================================
  Files         129      129              
  Lines       73582    74394     +812     
==========================================
+ Hits        63067    64588    +1521     
+ Misses       8500     7800     -700     
+ Partials     2015     2006       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akinross akinross force-pushed the 1307_bug_fix_read_only_legacy_block branch from 699a352 to 2488641 Compare January 29, 2025 20:50
@akinross akinross force-pushed the 1307_bug_fix_read_only_legacy_block branch 2 times, most recently from c6ba61d to bdc7a72 Compare January 29, 2025 21:52
@akinross akinross force-pushed the 1307_bug_fix_read_only_legacy_block branch from aa081eb to c0cd67d Compare January 30, 2025 13:01
@akinross akinross force-pushed the 1307_bug_fix_read_only_legacy_block branch 2 times, most recently from bff2016 to 953c584 Compare January 30, 2025 18:40
@akinross akinross force-pushed the 1307_bug_fix_read_only_legacy_block branch 4 times, most recently from b54237c to 5ea56e6 Compare January 31, 2025 10:57
@akinross akinross force-pushed the 1307_bug_fix_read_only_legacy_block branch from 5ea56e6 to ca5a708 Compare January 31, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants