Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPA rules - implications and explanation #150

Open
NathanDotTo opened this issue Jan 5, 2024 · 1 comment
Open

OPA rules - implications and explanation #150

NathanDotTo opened this issue Jan 5, 2024 · 1 comment

Comments

@NathanDotTo
Copy link
Contributor

In the bin/config_build.sh we have:

# Uncomment the line below if you want to enforce the OPA rules in `config/policy/config.rego`
#set -e

That probably needs some additional explanation, but I am not sure how to explain that. Any ideas please?

@ljakab
Copy link
Member

ljakab commented Jan 8, 2024

https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html

When there are multiple commands in a script, if one fails, by default Bash continues with the next, and the exit code of the failed command is lost. By setting set -e we instruct Bash to exit the script after a failed command. So if bin/config_build.sh right now the script will continue even if checks fail. If we un-comment that line, that won't be the case anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants