-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added VyOS #47
Added VyOS #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting! We love new contributors. I had a few somewhat small comments, and an ask for a bit more CML user-friendly docs on the qcow2 creation bit.
loopback: | ||
- lo | ||
ui: | ||
visible: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why false
? This should be true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified on my fork
id: VyOS-Router | ||
general: | ||
nature: router | ||
description: Opensource Router and Firewall Platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to use |-
and include a bit more details such as a link to the VyOS docs.
bcf23ff
to
2e5fffd
Compare
2e5fffd
to
f924256
Compare
I'm still learning git. I nuked what I was doing on accident trying to squash. I'll figure it out and try again. |
The above should be resolved. It was very messy -- I had to ask a colleague to help find the disconnected commits. |
++ node-definition/vyos/README.md ++ node-definition/vyos/VyOS-Router.yaml ++ virl-base-images/vyos/VyOS-1.5-rolling-XXX ++ virl-base-images/vyos/proxmox-instructions.md ++ virl-base-images/vyos/virt-install-instructions.md
fc9e586
to
2a7513c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! Great work. |
I read and tried to follow the contributing guidelines.
I added VyOS. I'm active on the Cisco Study Group Discord.