Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication date format improvements #6713

Open
FediVideos opened this issue Nov 8, 2024 · 5 comments
Open

Publication date format improvements #6713

FediVideos opened this issue Nov 8, 2024 · 5 comments
Labels
Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor UI non-trivial UI changes, that might need discussion

Comments

@FediVideos
Copy link
Contributor

FediVideos commented Nov 8, 2024

Describe the problem to be solved

At the moment dates (at least on English language version) are shown as MM/DD/YY

This has a couple of drawbacks:
-Most countries (including many English-speaking ones like UK, Ireland, Australia etc) use DD/MM instead of MM/DD
-The two-digit year causes e.g. videos originally published in 1924 to look like they were published in 2024

(If anyone is wondering why people would upload stuff published in the 1920s, lots of films and animations are from that period and many are now entering the public domain due to the 95 year limit on US films.)

Describe the solution you would like

Changing format to DD/MM/YYYY would be easiest, but this might still leave problems in MM/DD countries. At least showing YYYY in either format would be very helpful :)

Alternatively, could there be options for instance admins on how they display publication dates?

@Chocobozzz
Copy link
Owner

Hi,

We display dates based on the web browser locale. But I understand it can be confusing.

At the moment dates (at least on English language version) are shown as MM/DD/YY

Can you list where are displayed such dates?

@Chocobozzz Chocobozzz added the Status: Waiting for answer Waiting issue author answer label Nov 12, 2024
@FediVideos
Copy link
Contributor Author

FediVideos commented Nov 14, 2024

I have Firefox set to en-gb, is that where it is deriving date format from? en-gb should be dd/mm though? It's only en-us that uses mm/dd.

If this is a browser issue should I close issue here and open issue on Firefox?

You can see an example just below the video here:

https://fedi.video/w/mnxJLqxaS9yejUAnZPNYcH

PeerTubeDates

@Chocobozzz
Copy link
Owner

Thanks! I think it's a PeerTube bug. Will investigate

@Chocobozzz Chocobozzz added Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor UI non-trivial UI changes, that might need discussion and removed Status: Waiting for answer Waiting issue author answer labels Nov 14, 2024
@FediVideos
Copy link
Contributor Author

Obviously this is very low priority, no worries if you don't have time, maybe I shouldn't have opened this issue. Apologies! I didn't realise it was in the browser, it thought this was something small and simple to do with PeerTube directly.

By the way, it does seem to definitely be the browser:

On Firefox on Linux, when setting browser to a non-English language PeerTube displays the date correctly as DD/MM/YYYY

On Safari on iOS, when setting browser to a non-English language PeerTube displays the date correctly as DD/MM/YYYY

@Chocobozzz
Copy link
Owner

maybe I shouldn't have opened this issue

You always should when you have a problem with peertube :) We should rely on the web browser local (en-UK, en-US etc.) to fix the bug. We currently use the web client page locale for now but we only have one locale for english (en-US), and so English people have this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor UI non-trivial UI changes, that might need discussion
Projects
None yet
Development

No branches or pull requests

2 participants