Skip to content

Commit 6ceb487

Browse files
makhmudjon-inadullaevMakhmudjon Inadullaev
and
Makhmudjon Inadullaev
authored
fix for suggestions (npm#320)
Co-authored-by: Makhmudjon Inadullaev <[email protected]>
1 parent f5649a8 commit 6ceb487

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

theme/src/components/variant-select.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,21 +48,19 @@ function VariantSelect(props) {
4848
id={match.variant.shortName}
4949
key={index}
5050
active={active}>
51-
<span aria-label={`${match.variant.title}. List items ${index + 1} of ${variantPages.length}`}>
52-
{match.variant.title}
53-
</span>
51+
{match.variant.title}
5452
</ActionList.Item>);
5553
});
5654

5755
const ariaLabelMenuButton=open ? 'Version release' : selectedItem.variant.title
5856

5957
return (
6058
<ThemeProvider>
61-
<label id="label-versions-list-item" htmlFor='variant-select'>Select CLI Version:</label>
62-
<ActionMenu id="versions-list-item" aria-labelledby="label-versions-list-item" open={open} onOpenChange={setOpen}>
59+
<label id="label-versions-list-item" htmlFor='versions-list-item'>Select CLI Version:</label>
60+
<ActionMenu open={open} onOpenChange={setOpen}>
6361
<ActionMenu.Button autofocus="true" aria-label={ariaLabelMenuButton}>{selectedItem.variant.title}</ActionMenu.Button>
6462
<ActionMenu.Overlay width="medium" onEscape={() => setOpen(false)}>
65-
<ActionList>
63+
<ActionList id="versions-list-item" aria-labelledby="label-versions-list-item">
6664
{items}
6765
</ActionList>
6866
</ActionMenu.Overlay>

0 commit comments

Comments
 (0)