Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #78

Open
1 of 4 tasks
sharkwouter opened this issue Jun 6, 2020 · 4 comments
Open
1 of 4 tasks

Increase test coverage #78

sharkwouter opened this issue Jun 6, 2020 · 4 comments

Comments

@sharkwouter
Copy link
Contributor

sharkwouter commented Jun 6, 2020

Currently we're running into issues because we are not really testing much and end up making breaking changes without noticing. I think we should be working on improving this. I propose unit tests to be build for the following:

  • Both types of authentication.
  • Changing the settings.
  • All functions which have routes.
  • Tests for all endpoints to check if authentication is asked like expected.

I think this would be most of what would be needed.

@sharkwouter
Copy link
Contributor Author

PR #76 adds tests for my functions which have routes.

@Samsagax
Copy link
Contributor

This is an ongoing process and a good practice for all new code. Most of the new PRs should have them.

Is still relevant as an issue?

@sharkwouter
Copy link
Contributor Author

I think out of the tasks set here, only one was worked on. This would be adding tests for functions which have routes. The other tasks are mainly security things.

@Samsagax
Copy link
Contributor

We should add two more files then: one requesting all our paths without authenticating and another requesting all our paths authenticated.

I'll get into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants