Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Meta/Post effects #41

Open
Chillu1 opened this issue Nov 11, 2023 · 0 comments
Open

Dynamic Meta/Post effects #41

Chillu1 opened this issue Nov 11, 2023 · 0 comments
Labels
enhancement New feature or request modifier logic request New modifier logic for more lacking functionality

Comments

@Chillu1
Copy link
Owner

Chillu1 commented Nov 11, 2023

Describe the solution you'd like
Being able to either add, or activate/deactivate meta and post effects on modifiers. Making it, so we can do custom logic while the effect is handled at runtime

Implementation
There are two approaches:

  1. Removing and adding meta/post effects inside the effect.
  2. Activating and deactivating them instead.

Activation/deactivation is much better for our ram usage, amount of cloning, and generally preferred.
We'd have an int that acts like a bitset that sets the flags of which meta and post effects are active. Storing the default bitset state, and defaulting to it on ResetState.

@Chillu1 Chillu1 added enhancement New feature or request modifier logic request New modifier logic for more lacking functionality labels Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modifier logic request New modifier logic for more lacking functionality
Projects
None yet
Development

No branches or pull requests

1 participant