Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added opt-in features #7652

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Added opt-in features #7652

wants to merge 8 commits into from

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Oct 28, 2024 •
edited
Loading

Summary of the changes (Less than 80 chars)

  • Added opt-in features.

Closes #7720

❓ Questions:

  • Please check the schema error definitions in ErrorHelper.cs.
    • Should I be setting an error code or specified by?
  • I'm returning one error for each application of the directive, is that correct?
    • In theory, we could be including information about the directive syntax position, arguments, etc.

📓 Spec notes:

  • Should we explicitly disallow empty and whitespace-only feature strings? *
  • Should we disallow whitespace or other characters within feature names, or leave it completely open? *
  • I've used includeOptIn instead of includeRequiresOptIn for introspection, as it seemed more clear, WDYT?

* stability strings as well.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.13%. Comparing base (bf43444) to head (2f31b5a).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7652      +/-   ##
==========================================
+ Coverage   74.05%   74.13%   +0.07%     
==========================================
  Files        2920     2931      +11     
  Lines      151493   151920     +427     
  Branches    17614    17661      +47     
==========================================
+ Hits       112194   112622     +428     
+ Misses      33445    33435      -10     
- Partials     5854     5863       +9
Flag Coverage Δ
unittests 74.13% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as ready for review October 30, 2024 09:13
@michaelstaib michaelstaib added this to the HC-14.2.0 milestone Nov 4, 2024
@glen-84 glen-84 added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Nov 14, 2024
@michaelstaib michaelstaib modified the milestones: HC-14.2.0, HC-14.4.0 Dec 3, 2024
@michaelstaib michaelstaib modified the milestones: HC-14.4.0, HC-14.5.0 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate
Projects
None yet
Milestone
HC-14.5.0
Development

Successfully merging this pull request may close these issues.

Implement @requiresOptIn
2 participants
@glen-84 @michaelstaib