Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py.typed #343

Merged
merged 1 commit into from
Nov 1, 2023
Merged

py.typed #343

merged 1 commit into from
Nov 1, 2023

Conversation

richardkiss
Copy link
Contributor

No description provided.

@richardkiss richardkiss requested a review from arvidn October 28, 2023 02:31
@coveralls-official
Copy link

coveralls-official bot commented Oct 28, 2023

Pull Request Test Coverage Report for Build 6674281647

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.021%

Totals Coverage Status
Change from base Build 6330800844: 0.003%
Covered Lines: 5158
Relevant Lines: 5545

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Oct 28, 2023

what does this do?
there's also a clippy warning: https://github.com/Chia-Network/clvm_rs/actions/runs/6674281647/job/18140915475?pr=343#step:4:337

@richardkiss
Copy link
Contributor Author

Clippy warning is new. I guess cargo-clippy changed since the last release.

It's a tag that indicates to mypy that it should read the type hints and use them for linting.

@richardkiss
Copy link
Contributor Author

I can fix the clippy recommendation separately.

@richardkiss
Copy link
Contributor Author

#344 <-- clippy fix

@arvidn arvidn closed this Oct 31, 2023
@arvidn arvidn reopened this Oct 31, 2023
@richardkiss richardkiss merged commit 9cd58a4 into main Nov 1, 2023
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants