remove the block fill rate limit of 70% when farming a block #19005
Conversation
arvidn
added
the
Changed
Pull Request Test Coverage Report for Build 12254251236Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| @@ -1081,7 +1081,7 @@ async def make_and_send_big_cost_sb(coin: Coin) -> None: | |||
| g1 = sk.get_g1() | |||
| sig = AugSchemeMPL.sign(sk, IDENTITY_PUZZLE_HASH, g1) | |||
| aggsig = G2Element() | |||
| for _ in range(169): | |||
| for _ in range(242): | |||
There was a problem hiding this comment.
do you want to comment what this magic number is
There was a problem hiding this comment.
yeah, it's not great. it's the number of transactions we need to fill the mempool sufficiently to trigger the expected number of rejections. going from fill rate 70% -> 100%, I simply took 169 / 0.7 to increase this number proportionally. I'll try to improve this a bit.
There was a problem hiding this comment.
Sent #19026 as an attempt to clarify this.
There was a problem hiding this comment.
I think I might prefer the simpler construct with a comment like Amine has above. The latest version here Arvid has more magic numbers :-)
Purpose:
to increase transaction rate
Current Behavior:
Farmers only fill blocks to 70% full
New Behavior:
Farmers fill blocks all the way. But blocks are compressed and have potential to fit more transactions.
Testing Notes: