Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File exclusion #194

Open
yrachelevi opened this issue Nov 1, 2023 · 4 comments
Open

File exclusion #194

yrachelevi opened this issue Nov 1, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@yrachelevi
Copy link

yrachelevi commented Nov 1, 2023

Add an option to exclude specific file from the scan by adding them to the config file or as a param

@yrachelevi yrachelevi added this to 2ms Nov 1, 2023
@yrachelevi yrachelevi moved this to Todo in 2ms Nov 1, 2023
@baruchiro baruchiro added enhancement New feature or request good first issue Good for newcomers labels Dec 28, 2023
@baruchiro
Copy link
Contributor

Hi @yrachelevi, when you're saying "filename", do you mean only when we scan files?

What about scanning Confluence, Discord, or Paligo? Do you want to be able to exclude files (items, maybe) there too?

@baruchiro
Copy link
Contributor

baruchiro commented Feb 11, 2024

I just noted this feature is already implemented in the filesystem plugin with the --ignore-pattern argument.

  • We must understand if this feature is relevant to all plugins.
  • The description of the flag must be more descriptive.
  • @Tzurrr please wait with this.

@baruchiro baruchiro moved this from Todo to In Progress in 2ms Feb 12, 2024
@yrachelevi
Copy link
Author

This feature won't be relevant for slack, discord, paligo.
the flag should be at the plugin level
thanks

@baruchiro
Copy link
Contributor

It is already implemented for the filesystem plugin, and we need to implement it for git, confluence, and paligo.
I suggest that each plugin will be implemented in a separate PR.

Originally posted by @baruchiro in #199 (comment)

@baruchiro baruchiro removed the status in 2ms Feb 28, 2024
@baruchiro baruchiro removed the good first issue Good for newcomers label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants