Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighted tasking to cover recent deals and all miners #190

Open
bajtos opened this issue Nov 18, 2024 · 2 comments
Open

Weighted tasking to cover recent deals and all miners #190

bajtos opened this issue Nov 18, 2024 · 2 comments

Comments

@bajtos
Copy link
Member

bajtos commented Nov 18, 2024

At LabWeek'24, we were recommended to tweak the tasking algorithm (deal sampling) so that:

  • New deals get tested soon after they are announced on the chain.
  • All miners have a reasonably recent Spark RSR, i.e. each miner must be tested frequently enough.

A possible solution is to move away from the current uniform sampling and implement something like the following (for example):

  1. Pick 1/3 of tasks by uniformly sampling deals made in the last 6 hours (assuming we already have a real-time view of all storage deals + fast finality) or the last week (in Spark v1 with manual deal ingestion)
  2. Pick per-miner tasks as follows:
    • Build a list of active miners not included in the tasks defined in the first step.
    • For each miner in that list, pick one of miner's deals and add it to the tasks.
    • If the list of tasks is larger than 1/3 of tasks-per-this-round, the trim the list.
  3. Pick the remaining tasks by uniformly sampling all deals older than 6 hours (or 1 week, depending on the parameter used in the first step).
@bajtos bajtos changed the title Bias deal sampling to cover recent deals and all miners Tasking bias to cover recent deals and all miners Nov 18, 2024
@juliangruber
Copy link
Member

This is also a topic for CEL to look at

@bajtos bajtos changed the title Tasking bias to cover recent deals and all miners Weighted tasking to cover recent deals and all miners Nov 21, 2024
@bajtos
Copy link
Member Author

bajtos commented Nov 21, 2024

Cross-posting from filecoin-project/service-classes#6 (comment)

  • Currently we are checking weighted on data stored. This means small-storing SPs won't get checked.
    • @Stebalien had the idea of blending a weighting of how much data an SP has and the time since have last checked an SP.
  • Idea of making it a two round thing
  • Idea of having some known failures cases where you expect nodes to fail as a way to catch "dishonest actors"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants