refactor(deps): migrate react-dom from v18.2.0 to v19.2.4#6712
Closed
digital-wizard48 wants to merge 1 commit intoChatGPTNextWeb:mainfrom
Closed
refactor(deps): migrate react-dom from v18.2.0 to v19.2.4#6712digital-wizard48 wants to merge 1 commit intoChatGPTNextWeb:mainfrom
digital-wizard48 wants to merge 1 commit intoChatGPTNextWeb:mainfrom
Conversation
Author
|
Closing this PR — CI checks are failing and automated fixes have been exhausted. Thank you for considering this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Dependency version bumps
react:^18.2.0→^19.2.4(peer dependency, must be upgraded together with react-dom)react-dom:^18.2.0→^19.2.4@types/react:^18.2.70→^19.0.0(type definitions for React 19)@types/react-dom:^18.2.7→^19.0.0(type definitions for React 19)Breaking change:
JSX.Elementremoved from global namespaceReact 19 removes the global
JSXnamespace (and thusJSX.Element). All usages inapp/components/ui-lib.tsxhave been replaced withReact.ReactElement, which is the explicit equivalent and the recommended approach going forward:Popover.childrenprop:JSX.Element→React.ReactElementPopover.contentprop:JSX.Element→React.ReactElementCard.childrenprop:JSX.Element[]→React.ReactElement[]ListItem.iconprop:JSX.Element→React.ReactElementNo changes needed for
createRootThe
createRootAPI imported fromreact-dom/clientis unchanged in React 19 and continues to work as before.Notes
yarnafter merging to install the updated packages.JSX.Element(not shown here), they will also need the sameJSX.Element→React.ReactElementsubstitution.ReactDOM.render(the legacy root API), but this codebase already usescreateRootexclusively, so no migration is needed there.This PR was auto-generated by Gittensor upgrade bot using Claude AI