⚡️ Optimize NotNull array extension

Author: Chasmical

Chasm.Collections/ArrayExtensions.cs

@@ -514,12 +514,15 @@ [Pure] public static ReadOnlyCollection<T> AsReadOnly<T>(this T[] array)
         {
             if (array is null) throw new ArgumentNullException(nameof(array));
             if (default(T) is not null) return array!;
-            return Array.FindAll(array, Typed<T>.NotNullPredicate)!;
-        }
 
-        private static class Typed<T>
-        {
-            public static readonly Predicate<T?> NotNullPredicate = static v => v is not null;
+            List<T> results = [];
+            for (int i = 0; i < array.Length; i++)
+            {
+                T? item = array[i];
+                if (item is not null)
+                    results.Add(item);
+            }
+            return results.ToArray();
         }
 
     }

Chasm.Collections/CHANGELOG.md

@@ -1,6 +1,7 @@
 # Chasm.Collections Changelog
 
 ### v2.4.2 (next)
+- ⚡️ Improved the performance of `NotNull` array extension by inlining the `Array.FindAll` call;
 - ⚡️ Microoptimized IL code size of `CollectionExtensions.Add` extensions;
 
 ### v2.4.1