Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring long method #122

Open
victorcaio06 opened this issue Nov 2, 2023 · 2 comments
Open

Refactoring long method #122

victorcaio06 opened this issue Nov 2, 2023 · 2 comments
Assignees
@victorcaio06
Labels
enhancement New feature or request

Comments

@victorcaio06
Copy link

victorcaio06 commented Nov 2, 2023 •
edited
Loading

Refactoring in the withVariantRequests method that is contained in the ShopifyProductUpdateRequest.java file from line 146 to 202.

I'm a student at the federal university of Ceará in Brazil, I'm currently in a course whose final work is to increase contributions to open source projects.

My contribution to this project is in the quality part, I saw that the withVariantRequests method has a Long Method code smell,
so I plan to refactor this method.

Long method found when using the PMD tool.

PMD
@ryankazokas ryankazokas added the enhancement New feature or request label Nov 3, 2023
@victorcaio06
Copy link
Author

The code smell has been refactored and remains in a pull request.

Request link: #124

@ryankazokas ryankazokas reopened this Nov 16, 2023
@ryankazokas
Copy link
Member

Please keep open until PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victorcaio06 victorcaio06

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryankazokas @victorcaio06