Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove aggregation bits from seen attestation cache #7265

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Nov 29, 2024

Motivation

As noted by @twoeths in #7260 (comment), the cache is used for whole committee and not just a single validator which means the cached aggregationBits would be incorrect if reused for another attestation from a different validator.

Description

Remove aggregation bits from seen attestation cache

@nflaig nflaig requested a review from a team as a code owner November 29, 2024 10:24
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 48.42%. Comparing base (cfe6c89) to head (71652ea).
Report is 3 commits behind head on devnet-5.

Additional details and impacted files
@@             Coverage Diff              @@
##           devnet-5    #7265      +/-   ##
============================================
- Coverage     48.44%   48.42%   -0.02%     
============================================
  Files           602      602              
  Lines         40321    40332      +11     
  Branches       2057     2056       -1     
============================================
- Hits          19532    19531       -1     
- Misses        20751    20763      +12     
  Partials         38       38              

@nflaig nflaig requested a review from twoeths November 29, 2024 11:50
Copy link
Contributor

@twoeths twoeths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nflaig nflaig merged commit 957684f into devnet-5 Nov 29, 2024
17 checks passed
@nflaig nflaig deleted the nflaig/remove-aggregation-bits branch November 29, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants