Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable all biomejs recommended rules #7153

Merged
merged 41 commits into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
bc6ea37
Enable recomended correctness/noVoidTypeReturn
nazarhussain Oct 11, 2024
ab71719
Enable recomended rule correctness/useYield
nazarhussain Oct 11, 2024
91f6054
Enable recomended rule performance/noAccumulatingSpread
nazarhussain Oct 11, 2024
6cc060b
Enable recomended rule performance/noDelete
nazarhussain Oct 11, 2024
07f7cd4
Enable recomended rule suspicious/noAsyncPromiseExecutor
nazarhussain Oct 11, 2024
edd44b1
Enable recommended rule suspicious/noDoubleEquals
nazarhussain Oct 11, 2024
3cf245a
Enable recommended rule suspicious/noDuplicateTestHooks
nazarhussain Oct 11, 2024
3d67f6a
Enable recommended rule suspicious/noExportsInTest
nazarhussain Oct 11, 2024
24ebdc0
Enable recommended rule suspicious/noFallthroughSwitchClause
nazarhussain Oct 11, 2024
f2756df
Enable recommended rule suspicious/noGlobalIsFinite
nazarhussain Oct 11, 2024
d6b4206
Enable recommended rule suspicious/noGlobalIsNan
nazarhussain Oct 11, 2024
019c3de
Enable recommended rule suspicious/noPrototypeBuiltins
nazarhussain Oct 11, 2024
2630c5e
Enable recommended rule suspicious/noShadowRestrictedNames
nazarhussain Oct 11, 2024
04a1138
Enable recommended rule suspicious/useDefaultSwitchClauseLast
nazarhussain Oct 11, 2024
65a9d2a
Enable recommended rule suspicious/useGetterReturn
nazarhussain Oct 11, 2024
224a439
Enable recommended rule style/noUnusedTemplateLiteral
nazarhussain Oct 11, 2024
2a5b647
Convert default case to unreachable code
nazarhussain Oct 11, 2024
51c6048
Enable recommended rule complexity/noForEach
nazarhussain Oct 11, 2024
9f526e7
Enable recommended rule complexity/noThisInStatic
nazarhussain Oct 11, 2024
630ce11
Enable recommended rule complexity/useFlatMap
nazarhussain Oct 11, 2024
a0045ea
Enable recommended rule complexity/useOptionalChain
nazarhussain Oct 11, 2024
7a7b367
Enable recommended rule complexity/useRegexLiterals
nazarhussain Oct 11, 2024
7e3d613
Reorganize the config structure
nazarhussain Oct 11, 2024
d96b4d6
Fix few typos
nazarhussain Oct 14, 2024
69b7fa6
Merge branch 'unstable' into nh/biome-rules
nazarhussain Oct 14, 2024
4578725
Revert "Enable recomended rule performance/noDelete"
nazarhussain Oct 14, 2024
a04912c
Fix formatting
nazarhussain Oct 14, 2024
655a4d1
Enable recommended rule style/noUselessElse
nazarhussain Oct 14, 2024
ff5bb90
Enable recommended rule complexity/useLiteralKeys
nazarhussain Oct 14, 2024
dff8184
Enable recommended rule complexity/useArrowFunction
nazarhussain Oct 14, 2024
2309803
Fix few types
nazarhussain Oct 14, 2024
d67458d
Fix a test file
nazarhussain Oct 14, 2024
7cfc88e
Fix formatting
nazarhussain Oct 14, 2024
6472918
Enable recommended rule suspicious/noImplicitAnyLet
nazarhussain Oct 14, 2024
b3243c1
Enable recommended rule complexity/noUselessEmptyExport
nazarhussain Oct 14, 2024
38e0c50
Fix types
nazarhussain Oct 14, 2024
a6531c7
Fix unti tests
nazarhussain Oct 14, 2024
b103cf5
Fix unit test
nazarhussain Oct 14, 2024
384b5cb
Fix lint error
nazarhussain Oct 14, 2024
d449d16
Fix a unit test pattern
nazarhussain Oct 14, 2024
4f31ed9
Fix formatting
nazarhussain Oct 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion biome.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@
"noConsoleLog": "error",
// There are lot of cases in our code that need a separate PR to enable this rule
wemeetagain marked this conversation as resolved.
Show resolved Hide resolved
"noImplicitAnyLet": "off",
"useDefaultSwitchClauseLast": "off",
"useGetterReturn": "off",
"noExtraNonNullAssertion": "error",
"noMisleadingInstantiator": "error",
Expand Down
1 change: 1 addition & 0 deletions packages/light-client/src/spec/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export function upgradeLightClientHeader(
const startUpgradeFromFork = Object.values(ForkName)[ForkSeq[headerFork] + 1];

switch (startUpgradeFromFork) {
// biome-ignore lint/suspicious/useDefaultSwitchClauseLast: We want default to evaluate at first to throw error early
nflaig marked this conversation as resolved.
Show resolved Hide resolved
default:
throw Error(
`Invalid startUpgradeFromFork=${startUpgradeFromFork} for headerFork=${headerFork} in upgradeLightClientHeader to targetFork=${targetFork}`
Expand Down