Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deserializeUint8ArrayBitListFromBytes ssz api performance issue #7206

Open
twoeths opened this issue Oct 29, 2024 · 1 comment
Open

deserializeUint8ArrayBitListFromBytes ssz api performance issue #7206

twoeths opened this issue Oct 29, 2024 · 1 comment
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@twoeths
Copy link
Contributor

twoeths commented Oct 29, 2024

Describe the bug

This ssz api takes 2.5% time of a holesky node subscribing to all subnets

Screenshot 2024-10-29 at 16 02 30

holesky_subscribe_all_subnets_main.cpuprofile.zip

Expected behavior

I see some Uint8Array.slice() api there, see if we can improve by using Uint8Array.subarray() to avoid memory allocation

part of #7186

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

unstable and v1.22.0
@twoeths twoeths added the meta-bug Issues that identify a bug and require a fix. label Oct 29, 2024
@twoeths
Copy link
Contributor Author

twoeths commented Oct 30, 2024

getAggregationBitsFromAttestationSerialized() really caused gc due to its memory allocation

Screenshot 2024-10-30 at 10 26 13

@twoeths twoeths mentioned this issue Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twoeths