Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pre / post fork types #7183

Open
nflaig opened this issue Oct 21, 2024 · 4 comments
Open

Rename pre / post fork types #7183

nflaig opened this issue Oct 21, 2024 · 4 comments
Labels
scope-devex Issues for improving developer experience.
Milestone

Comments

@nflaig
Copy link
Member

nflaig commented Oct 21, 2024

Somehing we should consider for the 2.0 release is to rename pre / post fork types as current semantics are confusing and require feature awareness of each fork instead of just knowing about the fork name itself, and order of forks, which is simple since it's alphabetical.

e.g.

ForkPreBlobs --> ForkPreDeneb

ForkBlobs --> ForkPostDeneb

isForkBlobs --> isForkPostDeneb

etc.

see https://github.com/ChainSafe/lodestar/blob/unstable/packages/params/src/forkName.ts

@nflaig nflaig added the scope-devex Issues for improving developer experience. label Oct 21, 2024
@philknows philknows added this to the v2.0.0 milestone Oct 21, 2024
@philknows
Copy link
Member

Related #7011

@ensi321
Copy link
Contributor

ensi321 commented Oct 21, 2024

What's the reason we want to wait for 2.0 to make this change? Seems to me is just a straightforward refactor in the code.

Unless this feature is notable enough that we want to promote it as part of 2.0 launch

@nflaig
Copy link
Member Author

nflaig commented Oct 21, 2024

What's the reason we want to wait for 2.0 to make this change?

we should avoid breaking changes to @lodestar/types without bumping the major version, in case of this refactor, I don't think it's that urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-devex Issues for improving developer experience.
Projects
None yet
Development

No branches or pull requests

4 participants
@ensi321 @nflaig @philknows and others