Repository navigation
Commit e55f307
bench 313 carried two findings its own table contradicts (#3553)
* bench 313 was one network blip from logging a key
The RPC endpoint carries its credential as a path segment, and Go folds the
whole request URL into *url.Error, which net/http returns from both Do and
NewRequest. Every error on that path went to log.Printf, so any transport
failure would have written the key into the container log, which is the log
the audit bundles and a report quotes. The audit rated this plausible and
said it did not know whether the URL was keyed. It is keyed.
withoutURL keeps the operation and the cause and drops the address. The
guard has a test that puts the exact shape through it, including a wrapped
one, and the test asserts the input really does carry the key so a change
to net/url cannot make it vacuous. Disabling the guard fails it on all
three cases with the full endpoint in the message, which is the only way to
know a guard is a guard and not a comment.
An Inconclusive verdict counted as a FAILURE toward the confirmation rule.
Observe was handed `v == Sellable`, so everything that was not a clean sale
advanced the run: a node answering with an empty call list, a buy that
reverted, a read that timed out. 120 tokens drew Inconclusive in 9h30m. A
rule that exists to require two real failures was accepting two
non-answers. Only a definite verdict is recorded now.
LI.FI's row divided by 15 tokens where every other row divided by 26, which
made its rank a cohort artifact and not a measurement: on the same 15
tokens it ties Trnch at 66.7%, and the 14.1 point gap the board showed is
not there. The cause was not ordering, since surveyCohort already puts the
failed tokens first. It was budget. LI.FI publishes 75 requests per 20
minutes, the survey handed it 40 tokens a sweep, it earned a two hour
cooldown and then skipped 22 of 30 sweeps without asking anything at all,
never seeing those sweeps' failed tokens. Each aggregator now gets a
per-sweep budget from its own published limit, and no budget may cut into
the failed tokens, which are the prefix of the list and the only part the
score divides by. Answering every sweep about the few tokens that matter
beats answering one sweep in four about forty.
Eight of 26 tokens logged a bare "execution reverted" because error.data
was dropped and returnData came back 0x. The decoder that was inline in
revertReason is extracted so both fields go through one reader, and the
selectors are now recoverable: 0x63ecb9f6 is MinimalOutputBalanceViolation
and 0x5212cba1 is CurrencyNotSettled, both verified by hashing the
signature. An unsellable verdict is a claim about somebody's token and it
has to carry its evidence.
The held log line branched on Provisional, which is true for exactly the
runs it was meant to distinguish, so the "first observation" case was
unreachable and all 136 held lines claimed a prior sale. It branches on
Sold.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* bench 313 carried two findings its own table contradicts
Findings bullet 2 said the screening router and the deny-list router are
"both visible here as a low score". Neither is lowest. It asserted the
opposite of the board it introduces, about named companies, in the copy
that frames the page. It is rewritten to the durable claim: refusing to
route is a behaviour this board can see and a price board cannot, and
refusing in general is not the same as declining the specific tokens whose
exit failed.
Findings bullet 3 said tokens with an anti-bot cooldown are "most of a
launch cohort". Prometheus has 0 of that shape in 9h30m and 2 of 1573 over
a day, and a methodology bullet three lines earlier says the cohort is not
launches at all. The delayed sale is a guard against a rare shape, not a
filter against a common one, and it says so now, with the count.
The subtitle said the exit reverted "on the route they were bought
through". The sale is a SEPARATE quote, requested for the balance the buy
actually delivered. That was false and it was the first line of the page.
The probe size appeared nowhere, and the verdict depends on it: of seven
tokens whose round trip returned almost nothing at 0.02, four returned more
than a tenth at 0.002 and six at 0.0002. A reverted sale does not move with
size; what the exit is worth does. Both are now stated, along with the 99%
the code actually sells where the copy said 98%.
The delayed tab's own label still read "A few blocks later" after the
methodology started saying 36 seconds.
No percentage from the live board is typed into this copy. Every row's
figure moves with the floor removal and again with LI.FI's budget in #3552,
and a number written into a bullet today is a number that contradicts the
table tomorrow.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 8ddeafd commit e55f307
2 files changed
Lines changed: 17 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
64 | | - | |
| 63 | + | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
903 | 903 | | |
904 | 904 | | |
905 | 905 | | |
906 | | - | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
907 | 913 | | |
908 | 914 | | |
909 | 915 | | |
| |||
1254 | 1260 | | |
1255 | 1261 | | |
1256 | 1262 | | |
1257 | | - | |
| 1263 | + | |
| 1264 | + | |
1258 | 1265 | | |
1259 | 1266 | | |
1260 | 1267 | | |
| |||
1490 | 1497 | | |
1491 | 1498 | | |
1492 | 1499 | | |
1493 | | - | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
1494 | 1503 | | |
1495 | 1504 | | |
1496 | 1505 | | |
| |||
0 commit comments