-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementer Feedback: CAIP-122<>EIP-4361 mismatch #264
Comments
As of now, just checked some stuff, some kind of PR on CAIP-122 is probably necessary. pinging @ukstv to see if the message format in #236 was implemented by ceramic, not seeing it reflected here which makes me wonder if we need an alignment [meeting]
|
I will link this here as your table also mentions the attribute "address": #266 |
I think #236 does not make much sense as the CAIP-10 clearly defines an account ID including the namespace and chain ID as prefix. This makes the chain ID obsolete and I think the account ID is a good solution and well readable |
Maybe I am just confused why it is split up....? And why is it not also: |
@oed @haardikk21 @chris13524 you guys have opinions on reconciling these? i'm happy to open a PR and get a review from @jdsika off the top of my head but I've never implemented SIWX and have no idea what i'd be breaking! |
Also paging @0xproflupin for any thoughts here as well as it relates to SIWS compatibility. |
So I am the "fresh pair of eyes" on the whole thing but I may not know the backstory to some decisions. Suming up some things I think are actually inconsistencies:
Important as I realized while doing tezos-caip-122:
|
Hi guys, I found a couple of typos in the spec:
Joining a little bit the discussion here:
This seems like a conflict to me between making the protocol "efficient" against avoiding deprecating EIP-4361, seems like there's intention to avoid breaking changes in Ethereum.
|
Agreed, I added a commit wordsmithing this here - reapprove if that works for you?
Technically, this would be a nonconformant message, but since the EIP-4361 examples and tutorials and SDKs out there in the wild all use |
I see, in the Solana case would the use of |
valid yes; user-friendly, not so much. Designating official aliases could be done in a PR to |
In the case Chain ID was optional and CAIP-10 compliance required for address, devs would still be required to use Also "official aliases" seems to have a different description/meaning compared to "Chain ID" Or do you mean to replace it in CAIP-2? |
resources
is optional in EIP-4361 and required in CAIP-122 (although nothing stops it from being present but empty). both are still in review, but weight-bearing. presumably the path of least resistance/breakage is to keep it as-is, but add non-normative guidance warning people about this possibility (i.e. make "present but empty" explicitly allowed by 4361 to make sure implementers cover that case).The text was updated successfully, but these errors were encountered: