Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DTILES_content_gltf ? #282

Closed
bertt opened this issue Oct 4, 2023 · 3 comments
Closed

3DTILES_content_gltf ? #282

bertt opened this issue Oct 4, 2023 · 3 comments

Comments

@bertt
Copy link

bertt commented Oct 4, 2023

Hi, I'm getting the following error when validating a 1.1 tileset with GLB's and metadata:

EXTENSION_FOUND_BUT_NOT_USED - The extension '3DTILES_content_gltf' was found, but not declared in 'extensionsUsed'

Question: Is this error valid? What's the status of this 3DTILES_content_gltf extension?

@javagl
Copy link
Contributor

javagl commented Oct 7, 2023

This should not happen.

There are some open questions about the extension usage validation summarized in #231 , and the current implementation may have to be reviewed, but the basic approach is:

  • When the validator encounters tile content with the content type "glTF", then it tracks the 3DTILES_content_gltf as one "found" extension

  • At the end, it makes sure that all extensions that have been found are also declared in the extensionsUsed (and this should be the point where the validation error comes from)

  • But... for 3D Tiles 1.1, it is no longer necessary to declare the 3DTILES_content_gltf in the extensionsUsed, so even if it was found, it will be removed from the set of "found" extensions (that's ... a bit quirky, and marked as a TODO referring to the above issue)

Looking at the code, I noticed that this might be caused by a race condition: There should be an await at the beginning of this line.

Maybe you want to try out whether this solves the issue for you.
(But I'll add this in any case. And... we'll definitely have to enable some linting that detects these floating promises...)

Otherwise, it could be helpful if you could share that tileset.json or further information - e.g. does it use any extensionsUsed/extensionsRequired declarations? Does it declare the asset.version === "1.1"?

@bertt
Copy link
Author

bertt commented Oct 8, 2023

Ah yes that's it, fixed by changing asset.version from 1.0 to 1.1! Thanks!

@bertt bertt closed this as completed Oct 8, 2023
@javagl
Copy link
Contributor

javagl commented Oct 8, 2023

(When using 1.0, then addding 3DTILES_content_gltf to the extensionsUsed should also resolve the validation error, but since 1.1 is backward compatible, just declaring it as 1.1 is most likely the better solution here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants