Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6775] Added description to institution response #842

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[ENG-6775] Added description to institution response #842

merged 1 commit into from
Feb 18, 2025

Conversation

bodintsov
Copy link
Contributor

added description to institution response

@bodintsov
Copy link
Contributor Author

Added new field description and link to the property propertyPath to institutions' response.

@bodintsov bodintsov changed the title added description to institution response [ENG-6775] Added description to institution response Feb 18, 2025
@brianjgeiger brianjgeiger requested a review from aaxelb February 18, 2025 19:11
aaxelb
aaxelb approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@aaxelb aaxelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me ♦️

@aaxelb aaxelb changed the base branch from master to develop February 18, 2025 20:29
@aaxelb aaxelb merged commit 48e09d1 into CenterForOpenScience:develop Feb 18, 2025
2 checks passed
@coveralls
Copy link

Coverage Status

coverage: 91.737% (-0.005%) from 91.742%
when pulling a2f9e8e on bodintsov:feature/add-context-phrase-to-institutions-on-search-page
into da813d8 on CenterForOpenScience:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaxelb aaxelb aaxelb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bodintsov @coveralls @aaxelb