Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6654] indexer recover from connection errors #835

Merged

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Dec 2, 2024

improve the indexer daemon's handling of connection errors with rabbit

  • set heartbeat on the kombu connection
  • use kombu.Connection.ensure and kombu.Connection.autoretry to
    better handle errors when consuming or acking messages

@coveralls
Copy link

coveralls commented Dec 2, 2024

Coverage Status

coverage: 91.175% (-0.03%) from 91.201%
when pulling 609a36c on aaxelb:fix/indexer-errors-2024
into 8455a7e on CenterForOpenScience:develop.

@aaxelb aaxelb force-pushed the fix/indexer-errors-2024 branch 3 times, most recently from a9368d0 to 361517c Compare December 3, 2024 16:56
- set `heartbeat` on the kombu connection
- use `kombu.Connection.ensure` and `kombu.Connection.autoretry` to
  better handle errors when consuming or acking messages
@aaxelb aaxelb force-pushed the fix/indexer-errors-2024 branch from 361517c to 609a36c Compare December 3, 2024 17:01
@aaxelb aaxelb marked this pull request as ready for review December 3, 2024 17:02
@aaxelb aaxelb changed the title wip: indexer recover from connection errors [ENG-6655] indexer recover from connection errors Dec 3, 2024
@aaxelb aaxelb requested a review from mfraezz December 3, 2024 17:08
@aaxelb aaxelb changed the title [ENG-6655] indexer recover from connection errors [ENG-6654] indexer recover from connection errors Dec 3, 2024
@aaxelb aaxelb merged commit 24390ca into CenterForOpenScience:develop Dec 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants