Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6521] fix: include supplements in indexed data #830

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[ENG-6521] fix: include supplements in indexed data #830

merged 1 commit into from
Nov 4, 2024

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Nov 4, 2024 •
edited by jira bot
Loading

add as_rdfdoc_with_supplements method to IndexcardRdf models; use consistently when getting rdf content of an indexcard for indexing or derivation

ENG-6521

@aaxelb aaxelb force-pushed the fix/indexing-supplement branch from b4665a0 to 7618edd Compare November 4, 2024 15:13
@aaxelb aaxelb changed the title fix: include supplements in indexed data [ENG-6521] fix: include supplements in indexed data Nov 4, 2024
@aaxelb aaxelb force-pushed the fix/indexing-supplement branch from 7618edd to e4b7ffc Compare November 4, 2024 15:20
@aaxelb aaxelb force-pushed the fix/indexing-supplement branch from e4b7ffc to 83cd82e Compare November 4, 2024 15:27
@coveralls
Copy link

Coverage Status

coverage: 90.646% (-0.01%) from 90.656%
when pulling 83cd82e on aaxelb:fix/indexing-supplement
into 8b39c69 on CenterForOpenScience:develop.

@aaxelb aaxelb marked this pull request as ready for review November 4, 2024 16:21
@aaxelb aaxelb requested a review from cslzchen November 4, 2024 16:31
cslzchen
cslzchen approved these changes Nov 4, 2024
View reviewed changes
Copy link

@cslzchen cslzchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎆

I see the reduced coverage though I am not sure if it's a blocker for SHARE PRs. And it's only 0.01% ...

@aaxelb aaxelb merged commit ec39058 into CenterForOpenScience:develop Nov 4, 2024
2 of 3 checks passed
@aaxelb aaxelb deleted the fix/indexing-supplement branch November 4, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cslzchen cslzchen cslzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaxelb @coveralls @cslzchen