Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edit Last.fm Scrobbles] Edit from other pages - not just library #11

Open
nicoleahmed opened this issue May 7, 2024 · 4 comments
Open

Comments

@nicoleahmed
Copy link
Contributor

Hi
Is it possible to use this script outside of the "library" view

for example on track page: https://www.last.fm/user/nicoleahmed/library/music/Hybrid+Minds/_/Bad+To+Me+(feat.+Grace+Grundy)

The edit button shows but I can't edit using it

Thanks
Nicole

@nicoleahmed
Copy link
Contributor Author

i had a look at this last night but couldnt quite get my head around it
Think the issue is that there are minor differences in the library view compared to looking at "track view" or other views

Library view
image

Track view - no chartlist-artist but artist can be found elsewhere:
image
image
image

@CennoxX
Copy link
Owner

CennoxX commented May 9, 2024

The eventlistener isn't even added to the "Edit Scrobbles" button, so the problem accurs earlier in the process.

@nicoleahmed
Copy link
Contributor Author

Ah OK, thanks for looking - I think I'm probably not skilled enough to attempt troubleshooting but may give it a go

The main benefit of the track view is the same correction can be applied quickly /easily for all with the issue, within the 2 week time period. I will have a look at the code and look for the issue you've found

@CennoxX
Copy link
Owner

CennoxX commented May 9, 2024

@nicoleahmed If you're interested: I have managed to display the edit fields on track pages as well. The first steps can be found under this branch: https://github.com/CennoxX/userscripts/blob/last.fm-track-page/scripts/Last.fm%20Edit%20Scrobbles.user.js. But the feature still needs a lot of work. The track pages do not display title and artist, but title and album, in which case the artist would have to be fetched from another place and the album should be added to the script. The changes would then go so far that even the data sent to Last.fm would be different. I don't know if it's worth the work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants