-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish modernization of the tutorials repo #53
Comments
Once all the short term action items are done, we'll pull 54 |
Whoops, forgot to enable that, just need to add it to the conf
|
Other option would be to use the attrs_inline,but you'll still need to add that to the conf, so this seems simpler for now https://myst-parser.readthedocs.io/en/latest/syntax/images_and_figures.html#inline-images |
Done! now inline images are display correctly! |
I put the instructions in internal-use/docs/instructions.md |
Nice, exciting we got this merged! A couple cleanup tasks outstanding:
|
sounds good! just one question, all these modifications should be done in the Build modernization branch? |
Both those branches should now get deleted and work on #2 should start from a new clean branch! The first one will happen only in Transifex so no GH changes needed at this time. |
The easiest way to take advantage of the translation workflow we've ported over from bioimagingguide is to rather than build tutorials how we have been up until now (pandoc), we build them with Sphinx, where we can build either version with just a single flag switch. We can also bulk-build whole folders, and even easily make it so that you can access all the tutorials in a single page (this to me is the critical thing that keeps this from being an overengineering exercise). There are plugins we can use (see link and alternatives mentioned in it) to then also automate the PDF building, if we want. I'd love to eventually get to a place where we just make text edits in the markdown file, and then each tutorial builds itself in however many languages we support, makes the right zip files, puts them somewhere, etc, so all we need to do is worry about content and the rest takes care of itself. That might be a fun beginner-intro-to-GH-and-builds project.
Unfortunately a) we did not always structure things in a way that makes bulk-building a single file a great idea (some things have multiple top-row headings, for example) and b) Sphinx seems to take issue with the way we embed images sometimes for RST, etc. Fighting with RST at least preliminarily hasn't gone well, but since Sphinx supports MyST, which we know is super full-featured, this could be a better option.
So a few annoying things will need to get done, but for hopefully results we agree are worth it!
Once - short term
sphinx-build -b html -D root_doc=toc_en/index . ../build/html
, to build in Spanish runsphinx-build -b html -D language=es -D root_doc=toc_es/index . ../build/html_es
' - I took a first pass in our internal lab wikiPer current tutorial - short term
Go through and fix up. This includes
toc_en/index.rst
file (see Translocation example)scale
andwidth
(or evenwidth
andheight
) made weird squishiness, and some things had heights in pixels some in inches, etc. Each figure should havewidth
set only in terms of size parameters (plus possibly/probablyalign
,alt
, etc)Eventually
sphinx-build -b gettext . _build/gettext
thento make updated POTsphinx-intl update -p _build/gettext
/POfilesThe text was updated successfully, but these errors were encountered: