Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter.py tests fail on Python 3.7 but pass on Python 2.7, 3.5, and 3.6 #90

Open
cclauss opened this issue Oct 1, 2018 · 3 comments
Open

Comments

@cclauss
Copy link
Contributor

cclauss commented Oct 1, 2018

https://travis-ci.org/CellProfiler/centrosome/jobs/435518729#L2494

@AetherUnbound
Copy link
Collaborator

AetherUnbound commented Oct 1, 2018

This is likely why: https://docs.python.org/3/library/exceptions.html#StopIteration

Changed in version 3.7: Enable PEP 479 for all code by default: a StopIteration error raised in a generator is transformed into a RuntimeError.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 1, 2018

So how do we fix this?

@AetherUnbound
Copy link
Collaborator

AetherUnbound commented Oct 1, 2018

I think the best solution might be to replace the home-brewed permuation algorithm with a comparable numpy method, and ensure that all of the functionality is retained. Then we can just drop this block entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants