Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and fix hardcoded values #30

Open
simleo opened this issue Jun 23, 2017 · 0 comments
Open

Review and fix hardcoded values #30

simleo opened this issue Jun 23, 2017 · 0 comments
Assignees

Comments

@simleo
Copy link
Member

simleo commented Jun 23, 2017

The code contains several hardcoded values that we should get rid of. For instance, consider the current TrackMate reader. Both TrackMate examples currently list the following in their configuration file:

[TRACKING_DATA]
x_coord_cmso = POSITION_X
y_coord_cmso = POSITION_Y
z_coord_cmso = 
frame_cmso = FRAME
object_id_cmso = SPOT_ID
link_id_cmso = LINK_ID

Out of these, POSITION_{X,Y} and FRAME are used to look up information in the input TrackMate file, while SPOT_ID and LINK_ID are used as dataframe column headers (and eventually end up in the output .csv files). However, none of the above is actually read from the configuration file, it's all hardcoded.

See also: #8, #14.

@simleo simleo self-assigned this Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant