Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.6.2] Solar System Browser planet names are in gibberish #875

Closed
RacerBG opened this issue Nov 20, 2020 · 9 comments · Fixed by #877
Closed

[1.6.2] Solar System Browser planet names are in gibberish #875

RacerBG opened this issue Nov 20, 2020 · 9 comments · Fixed by #877
Labels
bug Something isn't working help wanted Extra attention is needed high priority native win Specific to native Windows frontend windows

Comments

@RacerBG
Copy link
Contributor

RacerBG commented Nov 20, 2020

Describe the bug
The names of the planets in the Bulgarian language (I guess the bug will be the same in Russian too) are in gibberish instead of Bulgarian.

To Reproduce

  1. Use the Bulgarian language (as I wrote I think Russian will be affected too).
  2. Open the Solar System Browser.

Expected behavior
The names of the planets should be in their native language.

Screenshots
bug

Desktop (please complete the following information):

  • Windows 7 SP1 x64
  • Frontend: Native
  • Version: 1.6.2 Final

I haven't noticed other other instances of this bug. I believe that this is a Unicode problem.

@375gnu 375gnu added bug Something isn't working help wanted Extra attention is needed high priority native win Specific to native Windows frontend windows labels Nov 20, 2020
@levinli303
Copy link
Collaborator

this is known, fixed in 1.7.0, but the backport #784 does not work, and we have no idea why it does not work.

@375gnu
Copy link
Member

375gnu commented Nov 20, 2020

As #322 states we don't have any windows developer. I'm unabe to reproduce this bug under wine.

@RacerBG
Copy link
Contributor Author

RacerBG commented Nov 20, 2020

As #322 states we don't have any windows developer. I'm unabe to reproduce this bug under wine.

I'm not a developer either but is there any way to help as a Windows user myself?

@375gnu 375gnu mentioned this issue Nov 20, 2020
3 tasks
@levinli303
Copy link
Collaborator

it seems we cannot use ListView_InsertColumn and some other methods, since their ANSI version does not support unicode

@375gnu
Copy link
Member

375gnu commented Nov 23, 2020

@RacerBG @Askaniy please test https://celestia.space/files/celestia/celestia-1.6.2.1.7z

@375gnu 375gnu added this to In Progress in Release 1.6.3 Nov 24, 2020
@Askaniy
Copy link
Member

Askaniy commented Nov 24, 2020

@375gnu

  • It fixed the names
  • It broke sharpness on the system scale not 100%
    image

@375gnu
Copy link
Member

375gnu commented Nov 24, 2020

It broke sharpness on the system scale not 100%

this fix doesn't contain any font rendering changes. are you sure that it was sharp before?

@levinli303
Copy link
Collaborator

on my win10 vm with 300% scaling, there was no change with scaling. was blurry, still blurry.

Release 1.6.3 automation moved this from In Progress to Done Nov 26, 2020
@levinli303 levinli303 linked a pull request Nov 26, 2020 that will close this issue
@Askaniy
Copy link
Member

Askaniy commented Nov 26, 2020

@375gnu I re-downloaded 1.6.2 and 1.6.2.1, installed them clean. Both are blurred, the update corrects the inscriptions. Apparently the last time 1.6.2 was launched with normal sharpness because of the path known to the system, where I could do some magic.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed high priority native win Specific to native Windows frontend windows
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants