Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star Flares #2

Open
CelestiaProject opened this issue Feb 2, 2017 · 10 comments
Open

Star Flares #2

CelestiaProject opened this issue Feb 2, 2017 · 10 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@CelestiaProject
Copy link
Collaborator

CelestiaProject commented Feb 2, 2017

In this topic Chris developed diffractive refraction effect, which occurs when watching the stars through a variety of optical instruments (telescopes, binoculars, etc.)

Unfortunately, Chris has not completed the effect, so it is not the repository.

@CelestiaProject CelestiaProject added enhancement New feature or request question Further information is requested labels Feb 2, 2017
@375gnu
Copy link
Member

375gnu commented Oct 7, 2018

I had a short email conversation with Chris and he suggested another, faster and simpler, implementation.

  • The texture has just a single 16-bit floating point channel; color is not "baked in" to the texture
  • The contents of the texture are multiplied by a value determined by the magnitude of the star
  • For the sake of performance, it's critical that the shader reduces the size of the point for fainter stars
  • Probably the toughest part is designing the texture. The center is a Moffat distribution; the halos are based on actual astrophotos

So technically this looks like "scaled disks" but with some adjustments.

@375gnu 375gnu added this to To do in Release 1.7.0 Dec 1, 2018
@SevenSpheres
Copy link
Contributor

Any progress on this?

@375gnu
Copy link
Member

375gnu commented Oct 21, 2019

nope :)

@SevenSpheres
Copy link
Contributor

@Askaniy, are you able to make this texture?

@375gnu
Copy link
Member

375gnu commented Oct 23, 2019

Such texture should be generated programmatically. I have a algorithm description and example of such texture but without halo, we agreed that galo is not needed as it's just an artifact.

@SevenSpheres
Copy link
Contributor

SevenSpheres commented Oct 23, 2019

I have a algorithm description and example of such texture

So there is progress then! :-)

SevenSpheres pushed a commit to SevenSpheres/Celestia that referenced this issue Apr 9, 2020
To keep the code up-to-date with the official repository
@SevenSpheres
Copy link
Contributor

@SevenSpheres
Copy link
Contributor

Is the development team aware of the old Celestia build from here ("svn5063 (+fading orbits, +new star rendering)")? It implements a similar star rendering to the EP one, but without diffraction spikes and apparently without artifacts around very bright stars. Screenshots here.

@375gnu
Copy link
Member

375gnu commented Sep 25, 2022

Our buggy branch is based on the same basically code.

@SevenSpheres
Copy link
Contributor

#1948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Release 1.7.0
  
To do
Development

No branches or pull requests

2 participants