-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update children positions when parent body is modified #1832
Labels
bug
Something isn't working
Comments
@SevenSpheres are you sure that you tested a proper build? That's what I have with the today's master: |
Still looks like my screenshot on the latest build. Tested on Win32, Qt5, and Qt6 frontends. |
I can reproduce both cases.
|
Can confirm, so this is probably a non-issue |
Then we need to recompute children positions on modification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At least with the build from the pull request, locations on Ceres are fixed with its actual oblateness, but I just found that if I modify an object to increase its oblateness to 0.5, locations are still floating in space:
![flatmars](https://private-user-images.githubusercontent.com/56284207/258609037-5ebfa2b9-a82f-4e26-b8ca-0b97c86ec3bf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5Nzg4NzEsIm5iZiI6MTcxOTk3ODU3MSwicGF0aCI6Ii81NjI4NDIwNy8yNTg2MDkwMzctNWViZmEyYjktYTgyZi00ZTI2LWI4Y2EtMGI5N2M4NmVjM2JmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDAzNDkzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3NzZlYjE2OGYwNzAwMmE3NzVjNGJmM2Y1ZmNhNDdhNTRiZjI0MjMwYzg5M2FlYTZiMDNiNjk2OWFhMTc3M2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1oFfxfQsQix_WPeGvbK6AxCY6vXVXimQjF9vYa7OsgM)
Originally posted by @SevenSpheres in #1557 (comment)
The text was updated successfully, but these errors were encountered: