Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand use of data from name references #28

Open
dhobern opened this issue Jul 7, 2022 · 5 comments
Open

Expand use of data from name references #28

dhobern opened this issue Jul 7, 2022 · 5 comments

Comments

@dhobern
Copy link

dhobern commented Jul 7, 2022

The COLDP files I submit to ChecklistBank include page numbers for most names and direct page links (to BHL pages) for many of them.

See for example how I have rendered Agdistopis sinhala here:

https://pterophoroidea.hobern.net/catalogue.php#taxon-12

The same data is presented in CLB like this:

https://www.checklistbank.org/dataset/1199/taxon/12

And in COL.org like this:

https://www.catalogueoflife.org/data/taxon/5TQCK

CLB shows more detail than COL.org - it would be nice to include all this in COL.org.

However, neither site shows the page numbers as provided in the source data and the links to the reference are the URLs from the reference record rather than the more specific ones in the name record.

@mdoering
Copy link
Member

mdoering commented Jul 7, 2022

Yes indeed. There are several problems and inconsistencies how we render references. Showing links for the main publishedIn reference was an addressed issue before:
CatalogueOfLife/checklistbank#1013

I would also prefer the links not to render the full URL but instead use an icon or small text like you do, Donald:

image

The reference citation can be generated with html markup and without in the backend. It seems we expose and use the text one only, as otherwise the journal would be standing out in italics which would be nicer. I would suggest to treat references the same way as we do with names and provide both a label and labelHtml instead of the current citation field. @thomasstjerne or do we still render CSL client side with the citeproc library?

We show references in many places, including the reference details page:
https://www.checklistbank.org/dataset/1199/reference/601

The main issue you raised though is about additional infos that allow to refer to a single page for names and also for taxon.accordingTo in the future.
This is page and pageLink specifically.

Here is a question: Do we want to deal with these 2 additionally to a reference which might already contain a page range, a DOI and a URL? Or would we rather modify the reference instance so the final CSL use just the more specific page and URL? I feel the later is better as it otherwise might be rather confusing to have both. And without it being part of the CSL instance we cannot include the specific page & link in the rendered citation but have to do this clientside somehow, e.g. in brackets behind the regular citation.

The specific page pointers only exist for Name.publishedIn and soon for Taxon.accordingTo. All other references don't have this option.

@thomasstjerne
Copy link
Collaborator

@dhobern I think you are after the publishedInPageLink which will show on taxon pages in CLB: https://www.dev.checklistbank.org/dataset/131219/taxon/531546

The reference rendering in CLB is based on the citation field which is then "linkified" i.e. URLs will be rendered as links. I would prefer to keep citation and then maybe add citationHtml to prevent breaking things and be backwards compatible.

@mdoering
Copy link
Member

mdoering commented Jul 7, 2022

I could also keep citation for some time while also adding label and labelHtml as the recommended thing to be more consistent?

@mdoering
Copy link
Member

mdoering commented Jul 7, 2022

Would it not be better to render all publishedIn information in one block with a single label? Maybe just place page as a link after the citation and if you have a page number make it page 1234 with or without a link? The thumbnail is obviously really nice to keep!

@mdoering
Copy link
Member

mdoering commented Jul 7, 2022

I could also keep citation for some time while also adding label and labelHtml as the recommended thing to be more consistent?

or can we just stick with citation and fill that with html? It is just italics, but it uses divs:

<div class="csl-entry">Greuter, W. (1911). <span style="font-style: italic">J. Linn. Soc., Bot.</span>, <span style="font-style: italic">10</span>(41), 141&ndash;156.</div>

We actually show both already for the source citations: https://www.checklistbank.org/dataset/2371/about
There we have citation and citationText :)

thomasstjerne added a commit to CatalogueOfLife/checklistbank that referenced this issue Jul 11, 2022
thomasstjerne added a commit to CatalogueOfLife/checklistbank that referenced this issue Jul 11, 2022
thomasstjerne added a commit that referenced this issue Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants