Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Geranium #688

Open
mdoering opened this issue Jul 16, 2024 · 3 comments
Open

Review Geranium #688

mdoering opened this issue Jul 16, 2024 · 3 comments
Assignees
Labels
xrelease extended release

Comments

@mdoering
Copy link
Member

mdoering commented Jul 16, 2024

It is a known well curated GSD
https://www.checklistbank.org/dataset/3LXRC/taxon/CDB6D

Species synonyms for a genus makes not much sense.
Do other mergers make sense?

World Flora Online Plant List 2024-06 seems to contribute a lot - which appears suspicous to me. Maybe we don't want to add names from that list if we have WFO already. Just the literature

@mdoering mdoering added the xrelease extended release label Jul 16, 2024
@mdoering mdoering added this to the XRelease Review milestone Jul 16, 2024
@DianRHR
Copy link
Contributor

DianRHR commented Jul 16, 2024

That merge is odd, the "Synonym Sources" doesn't inlcude those relations in their datasets:

  1. in WFO Plant List, Geranium baicalense is a synonym of Geranium krylovii. All the synonyms of Geranium are genera.
    Also, any source in CLB relates G. baicalense to Geranium. (through Names index search).

  2. In The Leipzig catalogue of vascular plants dataset, Geranium pratense Woronow is synonym of Geranium ruprechtii . This dataset doesn't include genera, all the species are directly under families, therefore the synonym relationship betqween genus and species didn't came from this ds.
    Also, any source in CLB relates G. pratense to Geranium. (through Names index search).

@camiplata
Copy link
Contributor

Currently there is still one species as synonym of the genus: Geranium baicalense wich as mention by Diana above is related to a specific species name at the source, not the genus, this could rather be a merging issue, what do you think @mdoering

Captura de pantalla 2024-10-16 a la(s) 6 55 16 p m

@camiplata camiplata removed this from the XRelease Review milestone Oct 17, 2024
@mdoering
Copy link
Member Author

mdoering commented Oct 18, 2024

Logs look as expected for the species:

% grep -n "Geranium baicalense" xcol.log

9648199:2024-10-12 06:51:08,520 DEBUG TreeMergeHandler            2004 process SYNONYM SPECIES Geranium baicalense Turcz. ex Besser -> KINGDOM Plantae Haeckel* | SUBKINGDOM Pteridobiotina Britton & Brown | PHYLUM Angiosperms | ORDER Geraniales Juss. ex Bercht. & J. Presl* | FAMILY Geraniaceae Juss.* | GENUS Geranium L.* | SPECIES Geranium krylovii Tzvelev*
9648200:2024-10-12 06:51:08,524 DEBUG TreeMergeHandler            2004 Geranium baicalense Turcz. ex Besser matches [NONE] 304443
9648201:2024-10-12 06:51:08,640 DEBUG TreeBaseHandler             2004 Created SYNONYM SPECIES usage Geranium baicalense Turcz. ex Besser from source 2004:CLMC9
9648202:2024-10-12 06:51:08,644 DEBUG TreeMergeHandler            2004 process SYNONYM VARIETY Geranium sylvaticum var. albiflorum Krylov -> KINGDOM Plantae Haeckel* | SUBKINGDOM Pteridobiotina Britton & Brown | PHYLUM Angiosperms | ORDER Geraniales Juss. ex Bercht. & J. Presl* | FAMILY Geraniaceae Juss.* | GENUS Geranium L.* | SPECIES Geranium krylovii Tzvelev* | SPECIES Geranium baicalense Turcz. ex Besser*
13451305:2024-10-12 10:54:40,501 DEBUG TreeMergeHandler            2232 process SYNONYM SPECIES Geranium baicalense Turcz. ex Besser -> FAMILY Geraniaceae* | GENUS Geranium Tourn. ex L.* | SPECIES Geranium krylovii Tzvelev*
13451306:2024-10-12 10:54:40,505 DEBUG TreeMergeHandler            2232 Geranium baicalense Turcz. ex Besser matches SYNONYM SPECIES Geranium baicalense Turcz. ex Besser [CLMC9 parent=CDB6D | nidx 10173883-10173884 | ref c4f7abfc-053a-4126-811a-a84126e7161f] [EXACT] 304443
13451307:2024-10-12 10:54:40,506 DEBUG TreeMergeHandler            2232 Update SYNONYM SPECIES Geranium baicalense Turcz. ex Besser from source 2232:2822902 with status SYNONYM
13451308:2024-10-12 10:54:40,509 DEBUG TreeMergeHandler            2232 process SYNONYM VARIETY Geranium sylvaticum var. albiflorum Krylov -> FAMILY Geraniaceae* | GENUS Geranium Tourn. ex L.* | SPECIES Geranium krylovii Tzvelev* | SPECIES Geranium baicalense Turcz. ex Besser*


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xrelease extended release
Projects
None yet
Development

No branches or pull requests

3 participants