Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pop up window when adding a sector #1509

Open
camiplata opened this issue Dec 1, 2024 · 2 comments
Open

Improve pop up window when adding a sector #1509

camiplata opened this issue Dec 1, 2024 · 2 comments
Assignees

Comments

@camiplata
Copy link
Collaborator

What is the purpose of having the UNION option set as default with adding a new sector on the assembly view? Both the text of the pop-up window and the CTA makes reference to UNION.

I would like to recommend having all options with the same desing and to display only the text once the option has been selected, and that such a text to be specific to the option selected.

Captura de pantalla 2024-12-01 a la(s) 4 32 30 p m
@mdoering
Copy link
Member

mdoering commented Dec 2, 2024

If you attach a sector is never makes sense if the target rank equals the subject rank, hence the default changes from attach to union. With merge sectors there is now another option than union. But I would expect people to manage merge sectors rather through the sector view than the assembly tree

@camiplata
Copy link
Collaborator Author

camiplata commented Dec 2, 2024

The project tutorial guides the user to use attach, and even if the default changes to union as a user one can still click on attach.
Then we may need to make several additional changes on the tutorial and on the UX.

Regarding the merge, using it in the assembly is explained on the tutorial wich I think is fine. It really depends on each project needs, if is better to add it from the assembly or from the sectors tabs. On the other hand, If merging in the assembly renders a bad behavior then it shouldn´t be an option all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants