Skip to content

Commit 9c6a469

Browse files
authored
Aleph BFT max round fix (#1037)
Fix of alephBFT misconfiguration.
1 parent 5172d74 commit 9c6a469

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bin/node/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "aleph-node"
3-
version = "0.10.0"
3+
version = "0.10.1"
44
authors = ["Cardinal Cryptography"]
55
description = "Aleph node binary"
66
edition = "2021"

finality-aleph/src/abft/common.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use std::{sync::Arc, time::Duration};
22

33
use crate::{NodeIndex, SessionId, UnitCreationDelay};
44

5-
const MAX_ROUNDS: u16 = 7000;
5+
pub const MAX_ROUNDS: u16 = 7000;
66

77
fn exponential_slowdown(
88
t: usize,

finality-aleph/src/abft/current.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@ use sp_blockchain::HeaderBackend;
55
use sp_runtime::traits::Block;
66

77
use crate::{
8-
abft::{common::unit_creation_delay_fn, NetworkWrapper, SpawnHandleT},
8+
abft::{
9+
common::{unit_creation_delay_fn, MAX_ROUNDS},
10+
NetworkWrapper, SpawnHandleT,
11+
},
912
crypto::Signature,
1013
data_io::{AlephData, OrderedDataInterpreter},
1114
network::data::Network,
@@ -70,6 +73,6 @@ pub fn create_aleph_config(
7073
) -> Config {
7174
let mut config = default_config(n_members.into(), node_id.into(), session_id.0 as u64);
7275
config.delay_config.unit_creation_delay = unit_creation_delay_fn(unit_creation_delay);
73-
76+
config.max_round = MAX_ROUNDS;
7477
config
7578
}

finality-aleph/src/abft/legacy.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use log::debug;
44
use sp_blockchain::HeaderBackend;
55
use sp_runtime::traits::Block;
66

7-
use super::common::unit_creation_delay_fn;
7+
use super::common::{unit_creation_delay_fn, MAX_ROUNDS};
88
use crate::{
99
abft::{NetworkWrapper, SpawnHandleT},
1010
data_io::{AlephData, OrderedDataInterpreter},
@@ -67,6 +67,6 @@ pub fn create_aleph_config(
6767
) -> Config {
6868
let mut config = default_config(n_members.into(), node_id.into(), session_id.0 as u64);
6969
config.delay_config.unit_creation_delay = unit_creation_delay_fn(unit_creation_delay);
70-
70+
config.max_round = MAX_ROUNDS;
7171
config
7272
}

0 commit comments

Comments
 (0)