-
Notifications
You must be signed in to change notification settings - Fork 829
Open
Labels
Game MechanicsRules complianceBringing the engine or cards closer to CRBringing the engine or cards closer to CR
Description
While looking at this part for #9532
forge/forge-game/src/main/java/forge/game/card/Card.java
Lines 3467 to 3476 in 2c0c656
| if (ck.isRemoveNonMana()) { | |
| // List only has nonMana | |
| if (null == mana) { | |
| list.removeIf(Predicate.not(SpellAbility::isManaAbility)); | |
| } else if (false == mana) { | |
| list.clear(); | |
| } | |
| } else if (ck.isRemoveAll()) { | |
| list.clear(); | |
| } |
and thinking on how to optimize it, like using a
Predicate,I noticed that it doesn't respect "Triggered mana abilities",
so the two cards that use it (maybe unify the property name?)
Town-Razer TyrantwithRemoveNonManaAbilitiesBlood SunwithExceptManaAbilities
Should, in the rare chance that something with a "Triggered mana ability" somehow got turned into a non-basic land,
have them keep these Triggers.
Metadata
Metadata
Labels
Game MechanicsRules complianceBringing the engine or cards closer to CRBringing the engine or cards closer to CR