Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "ingest" as a common, installable, endpoint #66

Open
ryckmanat opened this issue Dec 2, 2022 · 0 comments
Open

Create "ingest" as a common, installable, endpoint #66

ryckmanat opened this issue Dec 2, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@ryckmanat
Copy link
Contributor

The example servers all add an "/ingest" endpoint (which is, optionally, protected). It looks like this today:

    const ingestEndpoint = {
      method: ['POST'],
      handle: async () => {
        const changes = [] as Array<OfferChange>;
        const changeHandler = api.registerChangeHandler(async change => {
          changes.push(change);
        });
        await s.ingest();
        changeHandler.remove();
        return changes;
      },
    } as CustomRequestHandler;

Given that this is commonly wanted, we should move it to the opr-core library and make it easily installable in any server.

This should be created under opr-core/src/server/installable-endpoints/ingest.ts. Then, export the endpoint as a CustomRequestHandler.

@ryckmanat ryckmanat added the good first issue Good for newcomers label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant