Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Prism Launcher doesn't persist its files on uninstall #1065

Open
3 tasks done
redactedscribe opened this issue Dec 3, 2023 · 1 comment
Open
3 tasks done
Labels
bug Something isn't working

Comments

@redactedscribe
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

prismlauncher

Expected/Current Behaviour

On install, Prism Launcher persists some files, but not on uninstall. When reinstalling, the files found in persist/ are linked, but since they were not persisted on uninstall (as far as I can tell), the linked files are outdated. In particular accounts.json, prismlauncher.cfg, metacache.

E.g., hardlinks for prismlauncher.cfg:

D:\Scoop\apps\prismlauncher\8.0\prismlauncher.cfg
D:\Scoop\persist\prismlauncher\prismlauncher.cfg

After making an edit like changing where the program downloads files too, the hardlink is overwritten as a normal unlinked file.

Folders aren't affected I presume, so issue is only with the mentioned files.

Steps to Reproduce

- `scoop install prismlauncher`
- Run Prism Launcher and go to Settings > Launcher > Change downloads path for the sake of an edit. Quit.
- `scoop uninstall prismlauncher`
- `scoop install prismlauncher`, run, and notice downloads path has reset.

Possible Solution

Not sure.

Scoop and Buckets Version

Current Scoop version:
v0.3.1 - Released at 2022-11-15

'games' bucket:
0dc0faa1 (HEAD -> master, origin/master, origin/HEAD) rpcs3: Update to version 0.0.29-15783


### Scoop Config

```console
aria2-enabled : True
shim          : kiennq
last_update   : 03/12/2023 17:08:46
scoop_repo    : https://github.com/ScoopInstaller/Scoop
scoop_branch  : master


### PowerShell Version

```console
Name                           Value
----                           -----
PSVersion                      7.4.0
PSEdition                      Core
GitCommitId                    7.4.0
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0


### Additional Softwares

_No response_
@redactedscribe redactedscribe added the bug Something isn't working label Dec 3, 2023
@shinji257
Copy link

shinji257 commented Dec 15, 2023

This also happens with the accounts.json file. They are hard links when the package is initially installed then converted to normal files after that happens. The 0 byte files in the persist folder remain as such while the ones in the app folder increase as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants