Problems as a Windows user

[mcube27]

I use cakephp 3.8 and cakedc 1.0.1. on widnows10

I tried the command bin\cake fixture_import dump and I got denied access.

Looking into it I figured that out for windows users :

• Please indicate that grep should be downloaded or check for another way for windows users

• In FixtureImportShell, you use CONFIG path constant and add DS, but DS is already ending CONFIG path
  https://github.com/cakephp/app/blob/2cc749dfb76d4b76017e8fc491dcd735bd13ae5e/config/paths.php#L47
  

  cakephp-db-test/src/Shell/FixtureImportShell.php

  Line 60 in 6304795

  $dumpFolder = Hash::get($this->params, 'dump-folder', CONFIG . DS . 'sql');

  
  It should be $dumpFolder = Hash::get($this->params, 'dump-folder', CONFIG . 'sql');

• In MysqlEngine, you used single quotes around /*!50013 DEFINER and should use escaped double quotes
  

  cakephp-db-test/src/Engine/MysqlEngine.php

  Line 66 in 6304795

  $command = "mysqldump --extended-insert=FALSE $baseArgs $databaseName | grep -v -a '/*!50013 DEFINER'";

  
  It should be $command = "mysqldump --extended-insert=FALSE $baseArgs $databaseName | grep -v -a \"/*!50013 DEFINER\"";

• Finally in the same file, the file should be double quoted in case you have folder names with spaces like I do
  

  cakephp-db-test/src/Engine/MysqlEngine.php

  Line 68 in 6304795

  $command .= " > $file";

  
  It should be $command .= " > \"$file\"";

After fixing these I could get my dump where it should be!

I don't know if those changes affect unix users.

Hope it helps !

[steinkel]

Thank you for your input here, we're mainly using this tool in linux based environments but I'll keep this one to improve/allow windows users compatibility too. Thanks,