Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder url needs to keep 1 forward slash on unix/linux, and lose it if on Windows #12

Open
CaelCoruscare opened this issue Sep 5, 2023 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@CaelCoruscare
Copy link
Owner

file:///Users/cael/photos -> /Users/cael/photos

file:///C://Users/cael/photos -> C://Users/cael/photos

This must be a common issue. Surely other people on the internet have run into this. There's probably a better solution than testing for what the operating system is.

@CaelCoruscare CaelCoruscare added bug Something isn't working good first issue Good for newcomers labels Sep 5, 2023
@CaelCoruscare
Copy link
Owner Author

CaelCoruscare commented Sep 5, 2023

@toby, I made this because your fix for Windows broke the app on Mac. Turns out 'Users/cael/photos' does not actually work. You need the preceding forward slash.

@CaelCoruscare
Copy link
Owner Author

Maybe looking for a ':' at folderURL[1], after removing the QT 'file:///' part would work?

@CaelCoruscare
Copy link
Owner Author

@tobykestrel , I've set up a unit test case called "test_cleanURL". Please move the URL cleaning code from SlotBridge.FolderChosen() to ImageExtractor.cleanURL() and use the Unit Test to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants