Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate field mappings do not repair signatures #41

Open
TheGlitch76 opened this issue Sep 28, 2020 · 1 comment
Open

Duplicate field mappings do not repair signatures #41

TheGlitch76 opened this issue Sep 28, 2020 · 1 comment
Assignees

Comments

@TheGlitch76
Copy link

This is hard to explain, so have a chart:
This is Lorenz 0.5.4's current output, when merging int->obf (has signatures) and obf->srg (no signatures)

Left Right Output
name: A->B
signature: O
name: B->C
signature: null
name: A->C
signature: O
name: A->A
signature: O
name: A->A
signature: null
name: A->A
signature: null

I would expect the 2nd row, which is when the mappings are "loosely duplicated", to still copy over the signature name from the left mappings.

@DenWav
Copy link
Contributor

DenWav commented Sep 28, 2020

Current behavior is to assume right is most "correct" for duplicates, but I think it does make sense for that if the signature is null on the right but present on the left, to bring forward the signature from the left.

In the meantime you can fix this yourself with a custom MappingSetMergerHandler by overriding the relevant duplicate handler methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants