Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proton-cachyos: update nvapi-optical-flow.patch #400

Merged

Conversation

silvanshade
Copy link
Contributor

This PR updates proton-cachyos with the latest changes from the nvapi optical flow PR.

Copy link
Member

@ptr1337 ptr1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump the pkgrel to 3?

Besides that looks fine, thank you!

@silvanshade silvanshade force-pushed the proton-cachyos/update-nvapi-optical-flow branch from 34d8fb7 to 2f0e640 Compare October 30, 2024 13:04
@silvanshade silvanshade requested a review from ptr1337 October 30, 2024 13:05
@silvanshade
Copy link
Contributor Author

Could you bump the pkgrel to 3?

Done.

By the way, one thing I noticed is that I had a build failure the first time due to a missing Rust toolchain for i686.

I had to run the following and rebuild for it to succeed:

RUSTUP_TOOLCHAIN=stable rustup target add i686-unknown-linux-gnu

I'm guessing this doesn't show up in the automated environment if the full Rust environment is already set up beforehand.

Should I create another PR to add this step to prepare?

@ptr1337
Copy link
Member

ptr1337 commented Oct 30, 2024

Thank you!
Looks good now.

On archlinux/cachyos we are using the lib32-rust-libs, which should provide support for this. Users, which are using rustup need to manually the lib32 compiler.

@ptr1337 ptr1337 merged commit 4ccb6d5 into CachyOS:master Oct 30, 2024
@silvanshade silvanshade deleted the proton-cachyos/update-nvapi-optical-flow branch October 31, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants