Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2Crypto removal #41

Open
e3rd opened this issue Oct 14, 2024 · 0 comments
Open

M2Crypto removal #41

e3rd opened this issue Oct 14, 2024 · 0 comments

Comments

@e3rd
Copy link
Member

e3rd commented Oct 14, 2024

M2Crypto is a library we use for SMIME. We've recently migrated to cryptography.

  • the test are failing on the server https://github.com/CZ-NIC/envelope/actions/runs/11329031286/job/31503605563 . However, it's green on my local. Why? :D
  • There are still marks of M2Crypto. Remove it in favour of cryptography.
  • loading M2Crypto was slow (30 ms). Loading cryptography seem faster to me (1 ms). The imports might move to the module start.
  • is swig still needed for M2Crypto or we'll remove it from the readme and setup?

Please fork pull request to the new dev branch, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@e3rd