Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLs doesn't work with tibbles #24

Open
rasmus87 opened this issue Dec 30, 2020 · 1 comment
Open

FLs doesn't work with tibbles #24

rasmus87 opened this issue Dec 30, 2020 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@rasmus87
Copy link

Since the package is marketed as an addition to tidyverse, I think it is important all functions work with tibbles.

The function FLs() doesn't work with tibbles due to the functions use of reshape::melt(...).

The easiest fix (but not the best) is simply to replace reshape with reshape2.

The function could be rewritten to be based on tidyverse functions, to avoid problems like this.

@CWWhitney CWWhitney added bug Something isn't working enhancement New feature or request labels Jan 4, 2021
@CWWhitney
Copy link
Owner

I switched all the reshape to reshape2 (I only used melt from that package).
The package should be rewritten to tidy package standards.
That is something I would be grateful for collaboration on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants