Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIs, UVs, and simple_UVs are the same thing #21

Open
rasmus87 opened this issue Dec 21, 2020 · 2 comments
Open

CIs, UVs, and simple_UVs are the same thing #21

rasmus87 opened this issue Dec 21, 2020 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@rasmus87
Copy link

The calculation of both CIs UVs and simple UVs seems over excessive.
They all calculate the exact same thing correctly - but it seems error prone to do it in three different ways.

All three implementations calculate the exact same thing, and I would suggest using only one function and letting the other functions just refer to that one function.

The implementation of CIs looks cleanest and I would suggest the others just pointed to that.

@CWWhitney CWWhitney self-assigned this Dec 21, 2020
@CWWhitney CWWhitney added the bug Something isn't working label Dec 21, 2020
@CWWhitney CWWhitney added the enhancement New feature or request label Jan 4, 2021
@CWWhitney
Copy link
Owner

CWWhitney commented Jan 4, 2021

I have merged the functions.
Now UVs and simple_UVs all refer to the CIs function.
I am not satisfied that this is the ideal solution here but will leave it with these references for now. My thinking here is that if a researcher wants to calculate UVs or simple_UVs they should be able to find the formula in the vignette and the function in the package.

@KamilaBio
Copy link

@CWWhitney, Thank you for the development of the package! Is it possible to change the colors? which function do you use to change the colors of the CIs-plot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants