Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underwhelmed by the misuse of versionType and version to support purl #320

Open
prabhu opened this issue May 30, 2024 · 3 comments
Open
Labels
enhancement New feature or request section:affected_product Schema location is affected or product

Comments

@prabhu
Copy link

prabhu commented May 30, 2024

Like many, I was very excited to explore the 5.1 release with purported support for package url. But it turned out to be just a couple of string attributes versionType and version, that can be used to populate with any values without any validations. In fact, versionType could be purl, package url, PURL, anything. While purl specification has no limit on the length, version attribute has a max length of 1024, which would limit the number of qualifiers (Example repository_url=full url) that can be used.

I think if we are serious about replacing CPE with purl, it deserves a first party attribute with correct validation rules. I would appreciate if you revisit the purl support for 5.2 release.

@chandanbn
Copy link
Collaborator

Is it possible to check if something is a valid PURL using JSON-schema rules?

@prabhu
Copy link
Author

prabhu commented May 31, 2024

Thank you for the prompt response. If the attribute is called purl that alone is usually sufficient for the downstream tools to use appropriate validation.

Below is how CycloneDX handles the various identifiers.

https://github.com/CycloneDX/specification/blob/master/schema/bom-1.6.schema.json#L972-L999

CVE spec could support an array of purls, omnibor, and swhid etc similar to cpes.

@mprpic
Copy link
Contributor

mprpic commented Jun 3, 2024

@jayjacobs jayjacobs added the enhancement New feature or request label Oct 18, 2024
@jayjacobs jayjacobs added the section:affected_product Schema location is affected or product label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request section:affected_product Schema location is affected or product
Projects
None yet
Development

No branches or pull requests

4 participants