Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NUTS fully stateful in HybridGibbs #512

Open
nabriis opened this issue Sep 10, 2024 · 0 comments
Open

Make NUTS fully stateful in HybridGibbs #512

nabriis opened this issue Sep 10, 2024 · 0 comments
Assignees

Comments

@nabriis
Copy link
Collaborator

nabriis commented Sep 10, 2024

Let us work on getting the NUTS sampler fully stateful in HybridGibbs. This would mean no special case handling for NUTS in HybridGibbs.

Also relates to #474 and #505

Comment

do we lose NUTS step size here (epsilon, etc)? .. if so maybe we can print a warning

I also wonder if setting sampler.step_size = sampler.epsilon would be better than doing nothing, for NUTS. But it could be for another issue. What I mean is something like:

if isinstance(sampler, NUTS): 
                sampler.initial_point = sampler.current_point
                step_size = sampler.step_size
                
.
.
if not isinstance(sampler, NUTS): # Again, special case for NUTS.
                sampler.set_state(sampler_state)
                sampler.set_history(sampler_history)           
else:
                sampler.step_size = step_size

_Originally posted by @amal-ghamdi in https://github.com/CUQI-DTU/CUQIpy/pull/503#discussion_r1750386017_


            
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants