Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use placeholder tag for election official name and title #131

Open
paulschreiber opened this issue Sep 10, 2020 · 2 comments
Open

Use placeholder tag for election official name and title #131

paulschreiber opened this issue Sep 10, 2020 · 2 comments
Assignees
Milestone

Comments

@paulschreiber
Copy link
Collaborator

On elections.usdr.dev, we have

[Insert: County Name] Registrar of Voters
Jane Smith, Registrar of Voters

Expected:

[Insert: County] [Insert: Election Official Title]
[Insert: Election Official Name], [Insert: Election Official Title]
@bregman90
Copy link

Hm, where is this change?

@bregman90
Copy link

bregman90 commented Sep 11, 2020

If it is on the About Page, I am not quite sure we want that to be placeholder.

(1) If the first line item "[Insert: County Name] Registrar of Voters" is referring to the About Us header text, then actually that full string is "Registrar of Voters office" and not equivalent to the Election Official Title that is listed in Office Details.

(2) If "Jane Smith, Registrar of Voters" is referring to the About Us bio section, then maybe... but I'm not sure we want to enforce that the bio is equivalent to Election Official and Title. That might be better for admins to update manually. They might add multiple bios, choose which bio to feature, etc.

Better to keep using the Election Official Name and Title for the footer, as it currently is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants