-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable filtering of featureType in /location/contains #35
Comments
Where is the API documented? Is this a HTTP GET or POST? |
At the moment, it's deployed at https://api2.loci.cat/ and it's documented in the swagger/openapi doc at https://api2.loci.cat/api/v1/doc This is a HTTP GET currently. |
OK - so an example query might be I wonder if it should also be implemented via http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel3/80106/contains (probably as a redirect to the first version of course) |
BTW - could example calls be added to the Swagger? |
yes
the integration-api (api2.loci.cat) and the LD APIs (where http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel3/80106 resolves to) are two different components. what you are suggesting sounds like a feature for the LD API to extend it with spatial REST operators? |
Yes, I realise it requires ops on a different server, which may not be available. I'm suggesting a more RESTful pattern might be possible: where However, if a contains-service with arguments is what the market expects, then that is probably what we should provide. |
agree, but lets separate concerns on the components. for the integration-api (which interfaces with a cache of those LD resources) - agree the team did discuss an alternative when we were designing the APIs (more RESTful api endpoint for the call), which would be e.g. for uri http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel3/80106 where the URI is url-encoded. it is an option that the team has discussed previously. the reluctance was on the url-encoding of the URI which is an extra step... note: some doco here - https://github.com/CSIRO-enviro-informatics/loci-integration-api/wiki |
url-encoded is ugly if you do it manually. |
even if done automatically, it's an extra step a developer has to make (maybe not a big step). there are benefits to having it more RESTful and worth exploring. |
The current behaviour of /location/contains is that it returns all features that is contained within it.
It would be good to have an input flag, i.e. output_featuretype_uri, to enable users to specify which FeatureType instances are returned.
Example:
This would be useful for IDerdown for crosswalking.
The text was updated successfully, but these errors were encountered: